-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[CI] Add Simple GitHub-Action Based License Checker #20617
Conversation
Hey @barry-jin , Thanks for submitting the PR
CI supported jobs: [clang, miscellaneous, edge, sanity, windows-gpu, windows-cpu, unix-cpu, centos-cpu, centos-gpu, unix-gpu, website] Note: |
@mxnet-bot run ci [centos-gpu, unix-cpu, unix-gpu, website] |
Jenkins CI successfully triggered : [centos-gpu, unix-cpu, unix-gpu, website] |
@mxnet-bot run ci [website] |
Jenkins CI successfully triggered : [website] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed you remove the ASF header from the np files. Could you explain the rational?
The term "third-party work" refers to a work not submitted directly to the ASF by the copyright owner or owner's agent. This includes parts of a work submitted directly to the ASF for which the submitter is not the copyright owner or owner's agent.
Do not modify or remove any copyright notices or licenses within third-party works.
Make sure that every third-party work includes its associated license, even if that requires adding a copy of the license from the third-party download site into the distribution.
Do not add the standard Apache License header to the top of third-party source files.
Minor modifications/additions to third-party source files should typically be licensed under the same terms as the rest of the third-party source for convenience.
The project's PMC should deal with major modifications/additions to third-party source files on a case-by-case basis.
https://www.apache.org/legal/src-headers.html#3party
As there are major modifications/additions to the source files to integrate with MXNet, ASF header was previously added. Of course we can revisit this decision and relicense. Can you document why?
As stated in the MXNet1.9.0 rc7 voting thread, np_einsum_op.cc, np_einsum_op-inl.h and np_einsum_path_op-inl.h are adapted from numpy and they should stay under original license. https://www.apache.org/legal/src-headers.html#3party |
This pull request is also addressing some additional license issues listed in #20616 |
|
Nice work! |
Description
Add a simple license checker based on github action(apache/skywalking-eyes)
Note: For config file, I just copied rat-excludes into .licenserc.yaml. Will complete the config later.
Checklist
Essentials
Changes
Comments